[Bioperl-guts-l] bioperl-live/Bio/Graphics/Glyph Factory.pm, 1.18, 1.19

Lincoln Stein lstein at pub.open-bio.org
Tue Jul 12 08:41:01 EDT 2005


Update of /home/repository/bioperl/bioperl-live/Bio/Graphics/Glyph
In directory pub.open-bio.org:/tmp/cvs-serv14486/Bio/Graphics/Glyph

Modified Files:
	Factory.pm 
Log Message:
when a callback fails, warning code now identifies the callback more specifically


Index: Factory.pm
===================================================================
RCS file: /home/repository/bioperl/bioperl-live/Bio/Graphics/Glyph/Factory.pm,v
retrieving revision 1.18
retrieving revision 1.19
diff -C2 -d -r1.18 -r1.19
*** Factory.pm	16 Apr 2005 18:44:36 -0000	1.18
--- Factory.pm	12 Jul 2005 12:40:58 -0000	1.19
***************
*** 387,395 ****
        my $feature = $glyph->feature;
        return $value unless ref $value eq 'CODE';
-       # 23 July 2004 - commented this out because it was preventing whole segments from
-       # being passed to track callbacks.  This might cause problems elsewhere.
-       # return unless $feature->isa('Bio::SeqFeatureI');
        my $val = eval { $value->($feature,$option_name,$partno,$total_parts,$glyph)};
!       warn $@ if $@;
        return defined $val && $val eq '*default*' ? $GENERIC_OPTIONS{$option_name} : $val;
      }
--- 387,393 ----
        my $feature = $glyph->feature;
        return $value unless ref $value eq 'CODE';
        my $val = eval { $value->($feature,$option_name,$partno,$total_parts,$glyph)};
!       warn "Error returned while evaluating value of '$option_name' option for glyph $glyph, feature $feature: ",$@,"\n"
! 	if $@;
        return defined $val && $val eq '*default*' ? $GENERIC_OPTIONS{$option_name} : $val;
      }



More information about the Bioperl-guts-l mailing list