[Bioperl-guts-l] bioperl-live/Bio/Ontology SimpleOntologyEngine.pm, 1.14, 1.15 Term.pm, 1.27, 1.28

Heikki Lehvaslaiho heikki at dev.open-bio.org
Wed Jun 7 05:54:54 EDT 2006


Update of /home/repository/bioperl/bioperl-live/Bio/Ontology
In directory dev.open-bio.org:/tmp/cvs-serv1174/Bio/Ontology

Modified Files:
	SimpleOntologyEngine.pm Term.pm 
Log Message:
cleaning unnecessary "return undef"s

Index: SimpleOntologyEngine.pm
===================================================================
RCS file: /home/repository/bioperl/bioperl-live/Bio/Ontology/SimpleOntologyEngine.pm,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -d -r1.14 -r1.15
*** SimpleOntologyEngine.pm	13 Oct 2005 16:17:31 -0000	1.14
--- SimpleOntologyEngine.pm	7 Jun 2006 09:54:52 -0000	1.15
***************
*** 1,5 ****
  # $Id$
  #
! # BioPerl module for SimpleOntologyEngine
  #
  # Cared for by Peter Dimitrov <dimitrov at gnf.org>
--- 1,5 ----
  # $Id$
  #
! # BioPerl module for Bio::Ontology::SimpleOntologyEngine
  #
  # Cared for by Peter Dimitrov <dimitrov at gnf.org>
***************
*** 22,26 ****
  =head1 NAME
  
! SimpleOntologyEngine - Implementation of OntologyEngineI interface
  
  =head1 SYNOPSIS
--- 22,26 ----
  =head1 NAME
  
! Bio::Ontology::SimpleOntologyEngine - Implementation of OntologyEngineI interface
  
  =head1 SYNOPSIS
***************
*** 239,243 ****
   Usage   : get_term_by_identifier(String id): TermI
   Function: Retrieves terms from the term store by their identifier
!            field, or undef if not there.
   Example : $term = $soe->get_term_by_identifier("IPR000001");
   Returns : An array of zero or more Bio::Ontology::TermI objects.
--- 239,243 ----
   Usage   : get_term_by_identifier(String id): TermI
   Function: Retrieves terms from the term store by their identifier
!            field, or an empty list if not there.
   Example : $term = $soe->get_term_by_identifier("IPR000001");
   Returns : An array of zero or more Bio::Ontology::TermI objects.
***************
*** 573,577 ****
  sub _typed_traversal{
  	my ($self, $rel_store, $level, $term_id, @rel_types) = @_;
! 	return undef if !defined($rel_store->{$term_id});
  	my %parent_entry = %{$rel_store->{$term_id}};
  	my @children = keys %parent_entry;
--- 573,577 ----
  sub _typed_traversal{
  	my ($self, $rel_store, $level, $term_id, @rel_types) = @_;
! 	return if !defined($rel_store->{$term_id});
  	my %parent_entry = %{$rel_store->{$term_id}};
  	my @children = keys %parent_entry;
***************
*** 949,953 ****
    else {
  	  $self->warn("Term with id '$id' is not in the term store");
! 	  return undef;
    }
  }
--- 949,953 ----
    else {
  	  $self->warn("Term with id '$id' is not in the term store");
! 	  return;
    }
  }

Index: Term.pm
===================================================================
RCS file: /home/repository/bioperl/bioperl-live/Bio/Ontology/Term.pm,v
retrieving revision 1.27
retrieving revision 1.28
diff -C2 -d -r1.27 -r1.28
*** Term.pm	18 May 2006 22:34:15 -0000	1.27
--- Term.pm	7 Jun 2006 09:54:52 -0000	1.28
***************
*** 745,749 ****
      $self->throw("cannot manipulate authority prior to ".
                   "setting the namespace or ontology") if @_;
!     return undef;
  }
  
--- 745,749 ----
      $self->throw("cannot manipulate authority prior to ".
                   "setting the namespace or ontology") if @_;
!     return;
  }
  
***************
*** 834,836 ****
  *add_dblinks = \&add_dblink;
  
! 1;
\ No newline at end of file
--- 834,836 ----
  *add_dblinks = \&add_dblink;
  
! 1;



More information about the Bioperl-guts-l mailing list