[Bioperl-l] [bug 3120] Bio::DB::SeqFeature::Store::DBI::SQLite + bp_seqfeature_gff3.PLS = unhappy?

John Anderson genehack at genehack.org
Sun Jul 25 15:48:22 EDT 2010


On Jul 25, 2010, at 3:18 PM, Chris Fields wrote:

> On this one (in Bio::DB::SeqFeature::DBI::mysql):
> 
> if ( $typeid and $db_seqid and $start and $end and $strand ) {

Yeah, sorry, that sort of bugged me too, but once I got into testing stuff I forgot to go back and clean it up... 

> Might even work shortening to a grep:
> 
> if ( grep {!defined($_)} ($typeid, $db_seqid, $start, $end,$strand) ) {...}

Ended up with:

  # if we weren't called with all the params, pull those out of the database too
  if ( not ( grep { defined($_) } ( ... ))) { ... }

because having the negation buried inside the grep block seemed confusing...

I amended topic/bug-3120 and force-pushed it back to my tree; if you prefer the !defined($_) version just let me know -- still trying to get my head around the preferred house coding style. 8^)

j.




More information about the Bioperl-l mailing list