[Bioperl-l] Bio::Root::IO _readline/_pushback behavior

Chris Fields cjfields at illinois.edu
Fri Aug 5 11:50:42 EDT 2011


I would just go based on the test suite for now.  If we run into others that don't have tests we need to add new tests for those anyway.

chris

On Aug 5, 2011, at 3:40 AM, Kai Blin wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 2011-08-04 23:42, Chris Fields wrote:
> 
>> Yeah, it's a queue; the 'buffering' is a simple internal array using 
>> push/shift.  I say we merge the change in from the branch and fix
>> any modules accordingly.
> 
> Ok, I'm happy to take care of it, if people can tell me how to find and
> fix modules that use the old assumption. My initial attempt right after
> making the change was to run the test suite, which came up clean apart
> from the RootIO.t case that my patch now modifies as well.
> 
> Cheers,
> Kai
> 
> - -- 
> Dipl.-Inform. Kai Blin         kai.blin at biotech.uni-tuebingen.de
> Institute for Microbiology and Infection Medicine
> Division of Microbiology/Biotechnology
> Eberhard-Karls-Universität Tübingen
> Auf der Morgenstelle 28                 Phone : ++49 7071 29-78841
> D-72076 Tübingen                        Fax :   ++49 7071 29-5979
> Germany
> Homepage: http://www.mikrobio.uni-tuebingen.de/ag_wohlleben
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iQEcBAEBAgAGBQJOO6yZAAoJEKM5lwBiwTTPdjsH/0ELbz9VYIzxlpx+QZ3Jvd55
> KTXVP+oOzjIDlOdxbdqYR0w04VXnpkQek3hVt0mbreuKvtdMJY/YhRwZLiOzYSak
> ruhswUJQnm3K2vkaqpgLESIIUASneFrW7ezfV3R9q/Ov730GBDAtkLTEk7cVV5Cg
> W515ixJtNC7v6fZmNFJZudQbcUYYgy+8BFgvNUaSoH8YqubMXzjFXknBWeWT0qco
> ivHjqIc6Nkap799ijPiLEU7ArI1pEOB2jyvjntIocFR72imbo7e86RaVHJCNl/N7
> GFbRGoH2m7LVeWFYuNM3vsTS3W4KVLg9U/8UBysykR3uoHAVJhm4T5nCT4NKE/w=
> =z6QZ
> -----END PGP SIGNATURE-----
> _______________________________________________
> Bioperl-l mailing list
> Bioperl-l at lists.open-bio.org
> http://lists.open-bio.org/mailman/listinfo/bioperl-l




More information about the Bioperl-l mailing list