[Bioperl-l] Suggestion for Bio::PopGen::Statistics

Jason Stajich jason.stajich at gmail.com
Mon Nov 14 22:53:19 EST 2011


sure -- as you say, the implementation presumed that it would be called more than 3 individuals to this method which is a shortcoming.  I have committed the code fix but still need someone to add a comment to the perldoc. I've made it a redmine bug. 

https://redmine.open-bio.org/issues/3313

Jason

Can you provide a test script and we'll add a test for this so 
On Nov 13, 2011, at 9:42 AM, Cheng-Ruei Lee wrote:

> Hi all,
> 
>    Bioperl version: 1.006
>    Here are two error messages when I'm using this module to calculate Fu & Li's statistics:
> Illegal division by zero at (the Statistics.pm file) line 359
> Illegal division by zero at (the Statistics.pm file) line 376
>    A further tracking down shows that the first error happens when $n (sample size in the ingroup) equals 1 or 2, and the second error happens when $n equals 3. This is not really a bug though. I would suggest either in the original code, do a checking before the calculation (and skip the current calculation when $n == 1, 2, or 3 - rather than let the whole program die), or add a few lines of notes in the CPAN page.
> 
> Sincerely,
> Cheng-Ruei Lee
> _______________________________________________
> Bioperl-l mailing list
> Bioperl-l at lists.open-bio.org
> http://lists.open-bio.org/mailman/listinfo/bioperl-l




More information about the Bioperl-l mailing list